Skip to content

Add current_kdims for downstream#162

Merged
flying-sheep merged 6 commits into
mainfrom
manifold_map_dims
Jul 17, 2026
Merged

Add current_kdims for downstream#162
flying-sheep merged 6 commits into
mainfrom
manifold_map_dims

Conversation

@ahuang11

@ahuang11 ahuang11 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Builds on #161

Expose the key dimensions the plot is currently displaying (active reduction
plus the selected x/y axes) so downstream code can build a holoviews.Dataset
that a selection expression emitted by the plot resolves against, instead of
assuming a fixed reduction or axis order.

Also factors the axis-label → index parsing into a shared _dim_index helper
so current_kdims() and create_plot() stay in sync.

@ahuang11 ahuang11 changed the title fix dim Add current_kdims for downstream Jul 9, 2026
@ahuang11
ahuang11 requested a review from philippjfr July 13, 2026 15:21
Base automatically changed from fix_manifold_map to main July 15, 2026 18:42
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.36%. Comparing base (30c842e) to head (df8bc85).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   77.86%   78.36%   +0.50%     
==========================================
  Files          25       25              
  Lines        1771     1803      +32     
  Branches      218      218              
==========================================
+ Hits         1379     1413      +34     
+ Misses        311      309       -2     
  Partials       81       81              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@flying-sheep
flying-sheep merged commit 4ddfb20 into main Jul 17, 2026
10 checks passed
@flying-sheep
flying-sheep deleted the manifold_map_dims branch July 17, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants