Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Spatialpandas with dask-expr #1405

Merged
merged 6 commits into from
Feb 17, 2025
Merged

compat: Spatialpandas with dask-expr #1405

merged 6 commits into from
Feb 17, 2025

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 31, 2025

Uses a dev release tagged from holoviz/spatialpandas#171

Also removing all the legacy dask-dataframe logic in the tests.

@hoxbro hoxbro changed the title Try spatialpandas w. dask-expr compat: Spatialpandas w. dask-expr Jan 31, 2025
@hoxbro hoxbro changed the title compat: Spatialpandas w. dask-expr compat: Spatialpandas with dask-expr Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (6a5dbb3) to head (6a0e565).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datashader/tests/test_dask.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   87.04%   88.43%   +1.38%     
==========================================
  Files          93       93              
  Lines       18749    18641     -108     
==========================================
+ Hits        16321    16485     +164     
+ Misses       2428     2156     -272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from amaloney February 17, 2025 09:41
Copy link
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, and thanks for apply formatting standards

@hoxbro hoxbro merged commit f6dea71 into main Feb 17, 2025
12 checks passed
@hoxbro hoxbro deleted the spatialpandas_dask branch February 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants