Open
Conversation
jbednar
approved these changes
Oct 30, 2019
Member
jbednar
left a comment
jbednar
left a comment
There was a problem hiding this comment.
Looks great! Needs some examples in the docs, including the above example but also instantiating points with the centroid of the geohash rectangle, and indicating that the dependent library needs to be installed.
| def geohash_to_polygon(geo): | ||
| """ | ||
| :param geo: String that represents the geohash. | ||
| :return: Returns a Shapely's Polygon instance that represents the geohash. |
Member
There was a problem hiding this comment.
Suggested change
| :return: Returns a Shapely's Polygon instance that represents the geohash. | |
| :return: Returns a Shapely Polygon instance that represents the geohash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #372
We could separately add support for a pandas DataFrame with a 'geohash' column or more simply upgrade such a DataFrame to a geopandas DataFrame by converting the 'geohash' column to a 'geometry' column.