Skip to content

Fix hv.save for png images #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guillemdb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix hv.save for png images #4304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a36732
Fix hv.save as png images
Guillemdb Mar 19, 2020
826adb4
Update holoviews/plotting/renderer.py
philippjfr Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion holoviews/plotting/renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ def save(self_or_cls, obj, basename, fmt='auto', key={}, info={},

with StoreOptions.options(obj, options, **kwargs):
plot, fmt = self_or_cls._validate(obj, fmt)

if isinstance(plot, Viewable):
from bokeh.resources import CDN, INLINE, Resources
if isinstance(resources, Resources):
Expand All @@ -529,6 +528,11 @@ def save(self_or_cls, obj, basename, fmt='auto', key={}, info={},
resources = CDN
elif resources.lower() == 'inline':
resources = INLINE
if fmt not in ["html", "png", "auto"]:
raise ValueError("Format for exporting panel not supported: %s" % fmt)
fmt = 'html' if fmt == 'auto' else fmt
if basename.split('.')[-1] not in ('html', 'png'):
basename = "%s.%s" % (basename, fmt)
plot.layout.save(basename, embed=True, resources=resources)
return

Expand Down