Set the bounds of the kdims List parameter#5667
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5667 +/- ##
==========================================
- Coverage 88.29% 88.29% -0.01%
==========================================
Files 302 302
Lines 62541 62541
==========================================
- Hits 55220 55219 -1
- Misses 7321 7322 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
Member
Author
|
@hoxbro this could be merged safely, and need to be merged not to break HoloViews with Param 2.0. |
hoxbro
approved these changes
Apr 11, 2023
Member
|
Thank you for this 👍 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran the unit test suite of HoloViews with Param installed from holoviz/param#605 and a few tests failed. They failed when
kdimsListis overridden in a sub Parameterized class, and the overridingListis not defining explicitly the newbounds. In the current state of Param (1.x) ,boundsis not inherited from any super class but is always the default of(0, None)(meaning a list of any length). With the tested PRboundsis inherited.The change made in this PR was to set explicitly the
boundsin the subclasses. Alternatively, one could have loosenboundsin the super classes. The commits list what change was made and why. For instance, one could have setboundsofChart.kdims(super class) to(0, None)instead of updatingboundsonSpikes.kdims(sub class) to(0, None). I didn't spend much time thinking about doing the alternativeI noticed there are a few typos in the commits, here are the changes made:
(0,None)toSpikes.vdimsto overrideChart.vdimsbounds of(1, None)(3,3)toPath3D.vdimsto overrideGeometry.vdimsbounds of(2, 2)(3,3)toScatter3D.vdimsto overrideGeometry.vdimsbounds of(2, 2)(3,3)toTriSurface.vdimsto overrideGeometry.vdimsbounds of(2, 2)