Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6708 +/- ##
=======================================
Coverage 89.20% 89.21%
=======================================
Files 332 332
Lines 72010 72027 +17
=======================================
+ Hits 64240 64259 +19
+ Misses 7770 7768 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232 |
Member
Author
Member
|
I think we should replace the existing tests with a UI test. |
hoxbro
reviewed
Dec 4, 2025
hoxbro
reviewed
Dec 4, 2025
hoxbro
enabled auto-merge (squash)
December 4, 2025 18:53
Member
|
Thank you for adding testing 👍 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6232
This PR adds tests to verify that IndexError is properly suppressed when mouse/tap events occur outside the bounds of categorical axes on plots like HeatMaps, preventing crashes when users hover/click outside the plots or on colorbars or legends.