Skip to content

test: Add UI tests for Heatmaps IndexError fix (#6438)#6708

Merged
hoxbro merged 12 commits into
mainfrom
fix-6232
Dec 4, 2025
Merged

test: Add UI tests for Heatmaps IndexError fix (#6438)#6708
hoxbro merged 12 commits into
mainfrom
fix-6232

Conversation

@Azaya89

@Azaya89 Azaya89 commented Oct 22, 2025

Copy link
Copy Markdown
Member

Closes #6232

This PR adds tests to verify that IndexError is properly suppressed when mouse/tap events occur outside the bounds of categorical axes on plots like HeatMaps, preventing crashes when users hover/click outside the plots or on colorbars or legends.

@Azaya89 Azaya89 self-assigned this Oct 22, 2025
@codecov

codecov Bot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.21%. Comparing base (c717261) to head (d1561e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6708   +/-   ##
=======================================
  Coverage   89.20%   89.21%           
=======================================
  Files         332      332           
  Lines       72010    72027   +17     
=======================================
+ Hits        64240    64259   +19     
+ Misses       7770     7768    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Azaya89
Azaya89 requested a review from hoxbro October 22, 2025 15:18
@hoxbro

hoxbro commented Oct 23, 2025

Copy link
Copy Markdown
Member

I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232

@Azaya89

Azaya89 commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

I feel like the tests are too synthetic. Could we instead make a UI test that recreates the problem in #6232

Are you suggesting I replace the tests with something like the MRE in #6232 or just add the UI tests to these ones already written?

@hoxbro

hoxbro commented Oct 23, 2025

Copy link
Copy Markdown
Member

I think we should replace the existing tests with a UI test.

@hoxbro hoxbro added this to the 1.22.0 milestone Oct 24, 2025
@hoxbro hoxbro modified the milestones: 1.22.0, 1.22.1 Oct 31, 2025

@hoxbro hoxbro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that these tests fails, if we are running without the fix in #6438

@hoxbro hoxbro modified the milestones: 1.22.1, 1.22.2 Dec 1, 2025
@Azaya89
Azaya89 requested a review from hoxbro December 3, 2025 12:25
Comment thread holoviews/tests/ui/bokeh/test_hover.py Outdated
Comment thread holoviews/tests/ui/bokeh/test_hover.py Outdated
@hoxbro hoxbro changed the title fix: Add regression tests for Heatmaps IndexError fix (PR #6438) test: Add UI tests for Heatmaps IndexError fix (PR #6438) Dec 4, 2025
@hoxbro hoxbro changed the title test: Add UI tests for Heatmaps IndexError fix (PR #6438) test: Add UI tests for Heatmaps IndexError fix (#6438) Dec 4, 2025
@hoxbro
hoxbro enabled auto-merge (squash) December 4, 2025 18:53
@hoxbro

hoxbro commented Dec 4, 2025

Copy link
Copy Markdown
Member

Thank you for adding testing 👍

@hoxbro
hoxbro merged commit 47f696f into main Dec 4, 2025
25 of 35 checks passed
@hoxbro
hoxbro deleted the fix-6232 branch December 4, 2025 19:40
@hoxbro hoxbro modified the milestones: 1.22.2, 1.22.1 Dec 5, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The pointerXY stream breaks on heatmaps with categorical kdims

2 participants