enh: Support selector and ds.summary for geom_aggregator#6743
Merged
Conversation
selector and ds.summary for geom_aggregator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6743 +/- ##
===========================================
+ Coverage 21.18% 89.11% +67.92%
===========================================
Files 335 341 +6
Lines 72706 73241 +535
===========================================
+ Hits 15404 65268 +49864
+ Misses 57302 7973 -49329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
commented
Nov 26, 2025
Comment on lines
+845
to
+848
| if agg_state == AggState.AGG_BY: | ||
| params['vdims'] = list(map(str, agg.coords[agg_fn.column].data)) | ||
| elif agg_state == AggState.AGG_SEL_BY: | ||
| params['vdims'] = [d for d in agg.data_vars if d not in agg.attrs["selector_columns"]] |
Member
Author
There was a problem hiding this comment.
This is duplicated, but I think it is OK.
hoxbro
force-pushed
the
enh_support_selector_for_geom_aggregate
branch
from
November 26, 2025 11:08
f80227a to
c7d6e9b
Compare
hoxbro
force-pushed
the
enh_support_selector_for_geom_aggregate
branch
from
November 27, 2025 09:37
b46191b to
54936b9
Compare
hoxbro
force-pushed
the
enh_support_selector_for_geom_aggregate
branch
from
November 27, 2025 09:37
54936b9 to
e259826
Compare
hoxbro
marked this pull request as ready for review
November 27, 2025 09:52
hoxbro
commented
Nov 28, 2025
hoxbro
commented
Dec 1, 2025
Member
|
Let's merge after the patch release. |
philippjfr
approved these changes
Dec 17, 2025
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6736
Resolves #6739
Mostly factoring out logic in
aggregateto also use forgeom_aggregate. Not sure if I like the new method name, but just wanted to push this before it was lost in a stash. Know at least one test is failing because of change ofNdOverlaytoImageStack.Also fixes a bug where
__index__data was not sent to the frontend whenhover_tooltipswere used, so it would not hide tooltips.And handle
ds.bycases like what has been done aggregate.Summary
Screencast.From.2025-11-24.19-06-59.mp4
Selector
Screencast.From.2025-11-24.19-07-53.mp4
Simple
Screencast.From.2025-11-24.19-08-25.mp4