Skip to content

compat: Pandas 3.0.0#6749

Merged
hoxbro merged 12 commits into
mainfrom
compat_pandas_3_0_0
Dec 5, 2025
Merged

compat: Pandas 3.0.0#6749
hoxbro merged 12 commits into
mainfrom
compat_pandas_3_0_0

Conversation

@hoxbro

@hoxbro hoxbro commented Dec 4, 2025

Copy link
Copy Markdown
Member

Core test updates have been related to StringDtype.

Some changes were also needed with respect to Copy-on-Write (CoW)

Also decided to remove the global configuration in our test dask setting convert-string to False.

@hoxbro hoxbro changed the title update core tests compat: Pandas 3.0.0 Dec 4, 2025
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.34146% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.21%. Comparing base (47f696f) to head (afe83f1).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/tests/core/data/test_daskinterface.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6749      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         332      332              
  Lines       72027    72074      +47     
==========================================
+ Hits        64259    64299      +40     
- Misses       7768     7775       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread holoviews/tests/core/data/test_narwhalsinterface.py Outdated
@hoxbro
hoxbro force-pushed the compat_pandas_3_0_0 branch from 1843aff to 6ec6452 Compare December 4, 2025 18:38
@hoxbro
hoxbro marked this pull request as ready for review December 5, 2025 07:10
@hoxbro
hoxbro force-pushed the compat_pandas_3_0_0 branch from c29edbe to afe83f1 Compare December 5, 2025 10:13
Comment on lines +43 to +47
# convert-string will convert the object dtype to string
# even if the object is a list
# https://github.com/dask/dask/issues/10631
with dask.config.set({"dataframe.convert-string": False}):
data = dd.from_pandas(data, npartitions=1)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
import pandas as pd
import dask
import dask.dataframe as dd

with dask.config.set({"dataframe.convert-string": False}):
    ddf = dd.from_pandas(pd.DataFrame([{'value': [5, 5, 5]}]))

@hoxbro hoxbro added this to the 1.22.1 milestone Dec 5, 2025
@hoxbro
hoxbro merged commit 05417c2 into main Dec 5, 2025
29 of 32 checks passed
@hoxbro
hoxbro deleted the compat_pandas_3_0_0 branch December 5, 2025 13:24
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants