fix: NdMapping explicit tuple set slicing with dimension values#6780
Draft
fix: NdMapping explicit tuple set slicing with dimension values#6780
NdMapping explicit tuple set slicing with dimension values#6780Conversation
When slicing a DynamicMap with explicit tuple sets like `dmap[{(1, 0.3)}]`,
the operation failed with ValueError if any kdim had `values` defined.
The parent NdMapping.__getitem__ doesn't handle explicit tuple sets correctly
when dim.values is set. Fix by building the cache dict directly when both
`sample=True` (explicit tuple set) and any kdim has values defined, bypassing
the parent's slicing logic.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6780 +/- ##
=======================================
Coverage 89.23% 89.24%
=======================================
Files 340 340
Lines 73196 73229 +33
=======================================
+ Hits 65316 65352 +36
+ Misses 7880 7877 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
changed the title
NdMapping explicit tuple set slicing with dimension values
philippjfr
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4900
Handle the case for
NdMappingwhen the values of a slice are tuples.