Conversation
hoxbro
requested changes
Jan 31, 2026
Member
hoxbro
left a comment
hoxbro
left a comment
There was a problem hiding this comment.
I'm not against this, but I think we should careful in adding stuff simply for oneself.
I would like the information to be condenser, hidden by default (I don't want to see this when I open a PR every time), and link to developer guide for more information.
Some other comments;
- Even if we are following conventional commit syntax, we only require this for the title, not every commit. This could likely be expressed clearer in the documentation.
- Type of Change section is redundant, that is why we use conventional commits syntax. Note that breaking changes is done with exclamation point
compat!:
.github/pull_request_template.md
Outdated
| ## Checklist | ||
|
|
||
| - [ ] My PR title follows the conventional commit format shown above | ||
| - [ ] I have added tests |
Member
There was a problem hiding this comment.
Suggested change
| - [ ] I have added tests | |
| - [ ] I have added tests, and confirms that test suite is passing. |
hoxbro
approved these changes
Feb 4, 2026
Member
hoxbro
left a comment
hoxbro
left a comment
There was a problem hiding this comment.
I have tighten up the template a bit. If you are happy with that we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly for me than anybody else but I think it will also be helpful to new contributors as well.