Skip to content

enh: Remove use of explicit raise Exception#6866

Merged
hoxbro merged 3 commits into
mainfrom
enh_narrow_exceptions
May 4, 2026
Merged

enh: Remove use of explicit raise Exception#6866
hoxbro merged 3 commits into
mainfrom
enh_narrow_exceptions

Conversation

@hoxbro

@hoxbro hoxbro commented May 1, 2026

Copy link
Copy Markdown
Member

Description

Remove the use of explicit raise Exception

How Has This Been Tested?

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested all AI-generated content in my PR.
    • I take responsibility for all AI-generated content in my PR.

Tools and Models: Sonnet 4.6 + Opencode, Asked it to remove bare raise Exception

Checklist

  • Pull request title follows the conventional format
  • Tests added and is passing

@hoxbro
hoxbro force-pushed the enh_narrow_exceptions branch from 290909c to 91a4252 Compare May 1, 2026 14:49
@hoxbro hoxbro added this to the 1.23.0 milestone May 1, 2026
@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.52174% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.22%. Comparing base (7971661) to head (6416829).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/core/spaces.py 0.00% 12 Missing ⚠️
holoviews/core/io.py 0.00% 9 Missing ⚠️
holoviews/core/options.py 11.11% 8 Missing ⚠️
holoviews/plotting/util.py 0.00% 6 Missing ⚠️
holoviews/util/__init__.py 0.00% 5 Missing ⚠️
holoviews/core/element.py 0.00% 4 Missing ⚠️
holoviews/operation/element.py 0.00% 4 Missing ⚠️
holoviews/plotting/plot.py 0.00% 4 Missing ⚠️
holoviews/core/data/__init__.py 0.00% 3 Missing ⚠️
holoviews/core/dimension.py 0.00% 3 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6866      +/-   ##
==========================================
- Coverage   89.22%   89.22%   -0.01%     
==========================================
  Files         340      340              
  Lines       73955    73955              
==========================================
- Hits        65990    65987       -3     
- Misses       7965     7968       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread holoviews/core/ndmapping.py Outdated
@hoxbro
hoxbro force-pushed the enh_narrow_exceptions branch from d54391f to 6416829 Compare May 4, 2026 07:30
@hoxbro
hoxbro enabled auto-merge (squash) May 4, 2026 07:34
@hoxbro
hoxbro merged commit 0373d4a into main May 4, 2026
18 checks passed
@hoxbro
hoxbro deleted the enh_narrow_exceptions branch May 4, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant