Skip to content

fix: Add exception logging to Stream.trigger#6902

Merged
hoxbro merged 8 commits into
mainfrom
fix-stream6894
Jun 3, 2026
Merged

fix: Add exception logging to Stream.trigger#6902
hoxbro merged 8 commits into
mainfrom
fix-stream6894

Conversation

@Azaya89

@Azaya89 Azaya89 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Fixes #6894

This PR adds logging for exceptions raised in the stream subscriber system and also ensures that the remaining subscribers continue and not fail silently.

  • Pull request title follows the conventional format
  • Tests added and are passing

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.29%. Comparing base (e5e0ad6) to head (e12825f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/streams.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6902   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files         344      344           
  Lines       74881    74903   +22     
=======================================
+ Hits        66863    66884   +21     
- Misses       8018     8019    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Azaya89
Azaya89 requested a review from hoxbro June 2, 2026 12:59
Comment thread holoviews/streams.py Outdated
@hoxbro
hoxbro enabled auto-merge (squash) June 3, 2026 13:39
@hoxbro
hoxbro merged commit dc39978 into main Jun 3, 2026
18 checks passed
@hoxbro
hoxbro deleted the fix-stream6894 branch June 3, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream.trigger has no per-subscriber error isolation — one failing subscriber silently cancels every later subscriber's refresh

2 participants