Skip to content

feat: Add OHLC#6913

Open
ahuang11 wants to merge 8 commits into
mainfrom
add_ohlc
Open

feat: Add OHLC#6913
ahuang11 wants to merge 8 commits into
mainfrom
add_ohlc

Conversation

@ahuang11

@ahuang11 ahuang11 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Saw hvPlot had an OHLC plot, which is one of the first non-statistical charts available in hvPlot and not HoloViews, so I decided to ask AI to implement it in HoloViews.

Bokeh
image

MPL
image

Plotly (doesn't have a separate edge color for box because of its underlying implementation in plotly)
image

AI Disclosure

Tool & Model: Opus 4.8
Usage: Provided it context of hvplot and asked to implement across.

  • I have tested all AI-generated content in my PR.
  • I take responsibility for all AI-generated content in my PR.

Checklist

  • Pull request title follows the conventional format
  • Tests added and are passing
  • Added documentation

@ahuang11 ahuang11 changed the title Add ohlc feat: Add OHLC Jun 8, 2026
@ahuang11 ahuang11 added the type: feature A major new feature label Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.74214% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (409699b) to head (780eb4e).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/plotting/mpl/chart.py 92.59% 4 Missing ⚠️
holoviews/plotting/mixins.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6913      +/-   ##
==========================================
+ Coverage   89.29%   89.37%   +0.08%     
==========================================
  Files         344      348       +4     
  Lines       74554    75026     +472     
==========================================
+ Hits        66573    67057     +484     
+ Misses       7981     7969      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahuang11
ahuang11 requested a review from hoxbro June 9, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature A major new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant