allow latin1 encoding for csv files #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to add tests and refactor, but this does allow |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 55.87% 55.93% +0.06%
==========================================
Files 113 113
Lines 17150 17201 +51
==========================================
+ Hits 9582 9622 +40
- Misses 7568 7579 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Adds `chardet` as a dependency - Updates the two flows where data are ingested by Lumen; through an app and with the UI. - Reverts modifications to duckdb.py in favor of changes to the SQL transforms
ahuang11
reviewed
May 9, 2025
ahuang11
reviewed
May 9, 2025
ahuang11
reviewed
May 9, 2025
ahuang11
reviewed
May 9, 2025
ahuang11
reviewed
May 12, 2025
ahuang11
reviewed
May 12, 2025
Co-authored-by: Andrew <[email protected]>
ahuang11
approved these changes
May 12, 2025
ahuang11
added a commit
that referenced
this pull request
Jun 5, 2025
Co-authored-by: Andrew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.