Skip to content

Ensure consistent embeddings are used #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

Ensure consistent embeddings are used #1214

merged 5 commits into from
May 9, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 7, 2025

Closes #1210

If stored chunks was embedded with a certain embeddings model, but re-opened with another embeddings model, on query, it'll return no results.

@ahuang11 ahuang11 requested review from amaloney and philippjfr May 7, 2025 23:47
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.86%. Comparing base (47a6a47) to head (cd9b01d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/vector_store.py 72.34% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   55.80%   55.86%   +0.05%     
==========================================
  Files         113      113              
  Lines       17089    17152      +63     
==========================================
+ Hits         9537     9582      +45     
- Misses       7552     7570      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change to remove duplicated code, otherwise approved

@ahuang11 ahuang11 merged commit fe8c515 into main May 9, 2025
12 checks passed
@ahuang11 ahuang11 deleted the ensure_consistency branch May 9, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store embeddings used in vector store's metadata
2 participants