Skip to content

Prompt user to click Rerun if empty #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Prompt user to click Rerun if empty #1215

merged 3 commits into from
May 9, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented May 8, 2025

Improves the UX slightly by offering the user a path forward by injecting an SQL comment mentioning the query is invalid so the Planner and SQLAgent knows on the second try.

Addresses #1197

image
🗃️ Current SQL:
```sql
SELECT * FROM "windturbines.parquet" ORDER BY "p_cap" DESC LIMIT 5
-- No data was returned from the query.

📋 Last table: top_5_pcap

@ahuang11 ahuang11 requested review from amaloney and philippjfr May 8, 2025 00:17
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.79%. Comparing base (47a6a47) to head (eff2edf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/agents.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   55.80%   55.79%   -0.02%     
==========================================
  Files         113      113              
  Lines       17089    17094       +5     
==========================================
+ Hits         9537     9538       +1     
- Misses       7552     7556       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahuang11 ahuang11 merged commit 0cc419d into main May 9, 2025
12 checks passed
@ahuang11 ahuang11 deleted the retry_ux branch May 9, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants