Use hsplit for Navigation#1917
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 71.28% 71.29%
=======================================
Files 198 198
Lines 34268 34268
=======================================
+ Hits 24427 24430 +3
+ Misses 9841 9838 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
I'd also like to explore using a docked inline Drawer. |
Contributor
Author
sidebar.mp4Looks clean! |
ghostiee-11
requested changes
Jul 17, 2026
| "panel-graphic-walker[kernel] >=0.6.4", | ||
| "panel-material-ui >=0.8.1", | ||
| "panel-material-ui >=0.14.0", | ||
| "panel-splitjs >=0.3.2", |
Collaborator
There was a problem hiding this comment.
collapse_threshold=15 in _render_main was only added in panel-splitjs 0.4.0 (0.3.4 raises TypeError: unexpected keyword argument 'collapse_threshold'). CI passes because it resolves to 0.4.0, but anyone on 0.3.2-0.3.4 will crash when the UI builds. Should this be >=0.4.0?
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing, yes!
ahuang11
commented
Jul 17, 2026
ghostiee-11
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported styling to panel-extensions/panel-splitjs#30 and made Navigation bar also SplitJS, so it can be resized, and doesn't need to be in the left bar, which was confusing.
out.mp4