Skip to content

Tabulator: fix index out of bound error when updating table value with selected row and add_filter #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thuydotm
Copy link
Collaborator

Currently just a failing UI test to address #7525

Looks like the bug was in the event that passed into Tabulator._reset_selection() method.

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 71.31%. Comparing base (70551d3) to head (4ca76f6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7822      +/-   ##
==========================================
- Coverage   71.34%   71.31%   -0.03%     
==========================================
  Files         345      345              
  Lines       52935    52959      +24     
==========================================
+ Hits        37766    37769       +3     
- Misses      15169    15190      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant