Skip to content

Refactored some cdn urls #7826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nojaf
Copy link

@nojaf nojaf commented Apr 1, 2025

Related to #6161

@nojaf nojaf marked this pull request as ready for review April 2, 2025 09:49
@nojaf
Copy link
Author

nojaf commented Apr 2, 2025

Hi @philippjfr, any thoughts on this?

@philippjfr
Copy link
Member

Will have to test and review in detail but have you run panel bundle panel and then tried these components again?

@nojaf
Copy link
Author

nojaf commented Apr 2, 2025

Well, I must admit I'm seriously out of my game here.

It's been months since I used Panel, so a lot of things are less trivial to me right now.

I don't have panel available after running the editable install.

When running pixi run panel bundle --all (note that panel bundle panel isn't a command), something happened, although I'm not entirely sure it's what I'm after.

When I try out:

import panel as pn

pn.config.npm_cdn = "https://unpkg.com"
pn.extension('katex')
latex = pn.pane.LaTeX('${a}^{{{b}}} = {d}$')
latex.servable()

using:

pixi run panel serve sample.py --dev --show

I do see:

http://localhost:5006/static/extensions/panel/bundled/katex/[email protected]/dist/katex.min.js

in my network tab, so I'm guessing it didn't work?

Am I at least trying the right things here?

@philippjfr
Copy link
Member

Yep, that all sounds correct.

@@ -34,6 +35,10 @@ class VizzuChart(LayoutDOM):
f"{config.npm_cdn}/vizzu@{VIZZU_VERSION}/dist/vizzu.min.js"
]

@classproperty
def __javascript__(cls):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is correct. Let's skip Vizzu for now. We'll likely move it into an extension anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants