Skip to content

Deduplicate components before compiling #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2025
Merged

Deduplicate components before compiling #7887

merged 6 commits into from
May 8, 2025

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 5, 2025

Two changes:

  • Do not include the same component multiple times
  • If multiple components point to the same JS file do not duplicate it in the bundle

Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (2f6e822) to head (6d7be8c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
panel/io/compile.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7887       +/-   ##
===========================================
+ Coverage   47.48%   87.11%   +39.62%     
===========================================
  Files         334      346       +12     
  Lines       50666    53089     +2423     
===========================================
+ Hits        24060    46246    +22186     
+ Misses      26606     6843    -19763     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit abcf02f into main May 8, 2025
15 of 17 checks passed
@philippjfr philippjfr deleted the compile_once branch May 8, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant