Skip to content

test: Fix failing ui test#8172

Merged
philippjfr merged 1 commit into
mainfrom
fix_ui_test
Sep 3, 2025
Merged

test: Fix failing ui test#8172
philippjfr merged 1 commit into
mainfrom
fix_ui_test

Conversation

@hoxbro
Copy link
Copy Markdown
Member

@hoxbro hoxbro commented Sep 3, 2025

Follow up to #8163 (comment)

@hoxbro hoxbro changed the title test: Fix failing test test: Fix failing ui test Sep 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (bedda9c) to head (ddcbbaf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8172      +/-   ##
==========================================
+ Coverage   86.37%   87.36%   +0.99%     
==========================================
  Files         348      348              
  Lines       53700    53703       +3     
==========================================
+ Hits        46384    46919     +535     
+ Misses       7316     6784     -532     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
Copy link
Copy Markdown
Member

Just pushed my fix. I don't much like timeouts in tests but my change replaces the parametrization, which seems wasn't needed. I thought the problem was that selecting the current option didn't close the popup menu correctly, but that's not accurate it seems.

@philippjfr philippjfr merged commit 42cf3b0 into main Sep 3, 2025
18 checks passed
@philippjfr philippjfr deleted the fix_ui_test branch September 3, 2025 10:46
@hoxbro
Copy link
Copy Markdown
Member Author

hoxbro commented Sep 3, 2025

Tried a lot of things to avoid the timeouts. I think it is too quick to click on the next cell when updating, causing a raised condition somewhere. Couldn't see the problem with slowmo 200.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants