Interactive widgets in header- fixes #8353 #8357
Open
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8357 +/- ##
==========================================
- Coverage 86.12% 85.99% -0.13%
==========================================
Files 349 349
Lines 54709 54712 +3
==========================================
- Hits 47116 47052 -64
- Misses 7593 7660 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
approved these changes
Jan 5, 2026
philippjfr
reviewed
Jan 5, 2026
| if (path instanceof HTMLInputElement) { | ||
| const is_panel_widget = (el: EventTarget): boolean => | ||
| el instanceof HTMLElement && | ||
| Array.from(el.classList).some((c) => c.startsWith("bk-panel-models-widgets-")) |
Member
There was a problem hiding this comment.
Sadly I don't think this is really enough, because some widgets come from Bokeh and simply have a prefix like bk- and then there's panel-material-ui widgets which always just have this bk-panel-models-esm-ReactComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior: Previous #7057 specifically allowed TextInput objects in Card Headers, but the fix was specific to the TextInput widget and did not support any other interactive widgets (e.g. Select, Button, Slider, etc).
This PR, described in #8353 , generalizes based on CSS class to stop propagation of clicks which begin in any object which begins with
bk-panel-models-widgets-which could be tweaked if needed to catch the right level of specificity (I defer to the repo owners; please provide feedback).UI test has been updated (this updated test with a slider in the header was previously failing)
Linted and ran UI tests locally with no regressions, but this is my first PR on this repo!