Open
Conversation
1991645 to
f3ae051
Compare
rx objects can defer their computation completely until an explicit `.rx.value` is called.
f3ae051 to
6bb2127
Compare
Author
|
@philippjfr all stable now. Let me know if this is the way you envisioned the API or if there's a different approach you'd like me to try out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
+ Coverage 89.22% 89.26% +0.03%
==========================================
Files 9 9
Lines 4716 4723 +7
==========================================
+ Hits 4208 4216 +8
+ Misses 508 507 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@camriddell This is great, thanks for tackling this. I'll play around with it a bit but don't see any issues. @maximlt has also asked me to hold off on merging until we release a small patch release. So we should get this out some time in February I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional flag to
rx(..., lazy: bool = True | False). Whenlazy=Truechaining operations does not evaluate previous operations. Whereas whenlazy=Falsethe chaining a new operation evaluates the previous operation (original behavior).Addresses #1105
This is the current/original behavior
When using
lazy=True