Skip to content

Remove old Parameterized method stubs#592

Merged
maximlt merged 6 commits into
mainfrom
param_stubs_removal
Apr 12, 2023
Merged

Remove old Parameterized method stubs#592
maximlt merged 6 commits into
mainfrom
param_stubs_removal

Conversation

@philippjfr
Copy link
Copy Markdown
Member

Removes deprecated Parameterized methods which were moved onto the .param accessor.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #592 (34914ed) into master (c4a9e32) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   82.05%   81.99%   -0.06%     
==========================================
  Files           4        4              
  Lines        3014     2943      -71     
==========================================
- Hits         2473     2413      -60     
+ Misses        541      530      -11     
Impacted Files Coverage Δ
param/parameterized.py 82.26% <ø> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a9e32...34914ed. Read the comment docs.

Copy link
Copy Markdown
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Shouldn't tests/API0/__init__.py be deleted? Happy for this to be merged whenever is appropriate given the 1.x release schedule.

@maximlt maximlt merged commit d1c0a86 into main Apr 12, 2023
@maximlt maximlt deleted the param_stubs_removal branch April 12, 2023 10:48
@philippjfr
Copy link
Copy Markdown
Member Author

Wooooooo, thanks @maximlt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants