Skip to content

Resolves a Bug in Lift/Colift methods of ModulePresenationsForCAP - #1745

Merged
mohamed-barakat merged 2 commits into
homalg-project:masterfrom
kamalsaleh:master
Jul 1, 2025
Merged

Resolves a Bug in Lift/Colift methods of ModulePresenationsForCAP#1745
mohamed-barakat merged 2 commits into
homalg-project:masterfrom
kamalsaleh:master

Conversation

@kamalsaleh

@kamalsaleh kamalsaleh commented Jun 13, 2025

Copy link
Copy Markdown
Member

resolves #1744

@kamalsaleh kamalsaleh changed the title Resolves a Bug in Lift/Colift methods of ModulePresenationsForCAP: https://github.com/homalg-project/CAP_project/issues/1744 Resolves a Bug in Lift/Colift methods of ModulePresenationsForCAP Jun 13, 2025
@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (35b0c27) to head (cda804d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
+ Coverage   81.56%   81.70%   +0.14%     
==========================================
  Files         569      569              
  Lines       80802    80750      -52     
==========================================
+ Hits        65903    65976      +73     
+ Misses      14899    14774     -125     
Flag Coverage Δ
ActionsForCAP 64.04% <ø> (ø)
AttributeCategoryForCAP 90.45% <ø> (ø)
CAP 86.41% <ø> (ø)
CartesianCategories 89.38% <ø> (ø)
CompilerForCAP 95.89% <ø> (ø)
ComplexesAndFilteredObjectsForCAP 73.55% <ø> (ø)
FreydCategoriesForCAP 82.14% <ø> (ø)
GeneralizedMorphismsForCAP 61.73% <ø> (ø)
GradedModulePresentationsForCAP 44.62% <ø> (ø)
GroupRepresentationsForCAP 71.92% <ø> (ø)
GroupsAsCategoriesForCAP 96.69% <ø> (ø)
HomologicalAlgebraForCAP 73.21% <ø> (ø)
InternalExteriorAlgebraForCAP 93.09% <ø> (ø)
LinearAlgebraForCAP 57.41% <ø> (ø)
ModulePresentationsForCAP 75.01% <100.00%> (+5.12%) ⬆️
ModulesOverLocalRingsForCAP 90.70% <ø> (ø)
MonoidalCategories 89.84% <ø> (ø)
ToricSheaves 21.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kamalsaleh

Copy link
Copy Markdown
Member Author

Please don't merge until I make sure that no more changes are required

@kamalsaleh

Copy link
Copy Markdown
Member Author

It can now be merged once tests pass.

Comment thread ModulePresentationsForCAP/gap/ModulePresentationsForCAP.gi Outdated
Comment thread ModulePresentationsForCAP/gap/ModulePresentationsForCAP.gi Outdated
@mohamed-barakat

Copy link
Copy Markdown
Member

Could you please resolve this PR?

@mohamed-barakat
mohamed-barakat merged commit 3d391cc into homalg-project:master Jul 1, 2025
4 checks passed
@mohamed-barakat

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in ModulePresentationsForCAP

2 participants