Extract GroupsAsCats into new package - #1751
Merged
Merged
Conversation
Member
|
You should also delete the corresponding files in |
Collaborator
Author
They are moved from |
Member
|
I see |
Collaborator
Author
|
I guess the tests are failing because |
which is only loaded when FinSets is available. Otherwise there are call to methods from FinSets, which is not loaded in the CAP_project-CI. This results in warnings such as: Syntax warning: Unbound global variable MapOfFinSets Syntax warning: Unbound global variable GROUPS_AS_CATEGORIES_SkeletalFinSets
Collaborator
Author
|
There seems to be an issue with uploading to Codecov. |
mohamed-barakat
approved these changes
Jun 27, 2025
Member
|
Thanks @TKuh. |
Member
|
Could you please make a small PR to disable the attempt of pushing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.