Derivations for WeakKernelEmbedding/WeakCokernelProjection - #1761
Merged
Conversation
| objs := List( SetOfObjectsOfCategory( underlying_cat ), o -> ObjectConstructor( cat, [ o ] ) ); | ||
|
|
||
| tau := Concatenation( List( objs, | ||
| o -> Concatenation( BasisOfSolutionsOfHomogeneousLinearSystemInLinearCategory( cat, [ [ phi ] ], [ [ IdentityMorphism( cat, o ) ] ] ) ) ) ); |
Member
There was a problem hiding this comment.
Please put the "o ->" one line higher and the rest in the newline.
|
|
||
| objs := List( SetOfObjectsOfCategory( underlying_cat ), o -> ObjectConstructor( cat, [ o ] ) ); | ||
|
|
||
| tau := Concatenation( List( objs, o -> Concatenation( BasisOfSolutionsOfHomogeneousLinearSystemInLinearCategory( cat, [ [ phi ] ], [ [ IdentityMorphism( cat, o ) ] ] ) ) ) ); |
Member
There was a problem hiding this comment.
I meant to put the code starting from Concatenation( ... on the next line.
Member
|
Please also rebase and rebump the version number. |
They were previously in FreydCategoriesForCAP/gap/AdditiveClosureDerivedMethods.gi but this file got lost during the splitting of the other Weak* derivations from FreydCategoriesDerivedMethods.gi into AdditiveClosureDerivedMethods.gi in commit 486fc89
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1761 +/- ##
==========================================
- Coverage 81.78% 81.77% -0.01%
==========================================
Files 576 576
Lines 80857 80895 +38
==========================================
+ Hits 66127 66151 +24
- Misses 14730 14744 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were previously in
FreydCategoriesForCAP/gap/AdditiveClosureDerivedMethods.gibut this file got lost during the splitting of the otherWeak*derivations fromFreydCategoriesDerivedMethods.giintoAdditiveClosureDerivedMethods.giin commit 486fc89