Skip to content

Conversation

jackwellerreal
Copy link
Contributor

@jackwellerreal jackwellerreal commented Mar 6, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm build, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image
image

#2018

Copy link
Contributor

deepsource-io bot commented Mar 6, 2025

Here's the code health analysis summary for commits 0e1f693..c902f4d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 1 occurence introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@jackwellerreal
Copy link
Contributor Author

image
image

@jackwellerreal
Copy link
Contributor Author

Ive been inactive for a while, if anyone is wondering the progress of this. I am waiting for #2497 to be resolved, this is because of the "repositories" section which allows for nested options to be added and removed. That feature can be used to have more options for each piece of data you want to be shown and any titles or icons for that piece of data.
image

@manuel-rw
Copy link
Member

Hi @jackwellerreal , what is the state of this?
#2497 has been closed. Would be lovely to have this in Homarr!

@jackwellerreal
Copy link
Contributor Author

I'm currently busy with school, so maybe in a few weeks I'll pick it back up and finish it.

@jackwellerreal
Copy link
Contributor Author

image
image

@jackwellerreal
Copy link
Contributor Author

I'm demotivated to add multiple items to each widget and want to close the pr, if someone else wants to do that feel welcome

@jackwellerreal jackwellerreal marked this pull request as ready for review July 3, 2025 01:33
@jackwellerreal jackwellerreal requested a review from a team as a code owner July 3, 2025 01:33
@manuel-rw
Copy link
Member

I'm demotivated to add multiple items to each widget and want to close the pr, if someone else wants to do that feel welcome

No worries, we appreciate that you took your time and made it this far.
We can do that as a second iteration.

@manuel-rw manuel-rw requested a review from Meierschlumpf July 3, 2025 20:20
@manuel-rw manuel-rw added enhancement New feature or request integration New integration labels Jul 3, 2025
@Meierschlumpf
Copy link
Member

Hey, @jackwellerreal appreciate your work. I would like that the header value is stored encrypted in the database, therefore it might make the most sense to add a "custom integration" or another way to encrypt this option.

@jackwellerreal
Copy link
Contributor Author

Hey, @jackwellerreal appreciate your work. I would like that the header value is stored encrypted in the database, therefore it might make the most sense to add a "custom integration" or another way to encrypt this option.

I will have a look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request integration New integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants