fix: prevent GitHub releases check from blocking app on API failure#5807
Open
ajnart wants to merge 2 commits into
Open
fix: prevent GitHub releases check from blocking app on API failure#5807ajnart wants to merge 2 commits into
ajnart wants to merge 2 commits into
Conversation
72597de to
6e88ae5
Compare
Member
|
This one seems of (119 files for a small bugfix should not be necessary). It seems like you have unrelated changes in this pr |
Member
Author
I'm very confused how it got this bad, I'll fix it asap |
Fallback to stale Redis cache when the GitHub releases fetch fails, reduce check frequency to daily, and disable Octokit throttling for reliability.
3ed1adb to
28dd9dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fallbackToStaleOnErrorto the cached request handler so failed upstream fetches can return last-known-good Redis data instead of throwingCloses #5786
Context
Users reported Homarr becoming completely inaccessible when the GitHub releases endpoint returns quota errors — especially visible in regions where GitHub is unreliable. The update checker was hitting
GET /repos/homarr-labs/homarr/releasestoo often and Octokit would retry throttled requests, blocking admin page loads.Test plan
NODE_ENV=development pnpm exec vitest run packages/request-handler/src/test/update-checker.spec.ts