Skip to content

Conversation

@elibl
Copy link

@elibl elibl commented Jan 11, 2026

built and tested locally with emulated hardware

Summary by CodeRabbit

  • New Features

    • Force Z-Wave associations regardless of validity checks
    • Skip interviewing devices that fail Security S2 authentication
  • Bug Fixes

    • Resolved initial interview user code handling issues
    • Fixed Supervision command usage in configuration resets
    • Corrected sound switch configuration log messages
    • Fixed NVM backup hangs on select controllers
  • Improvements

    • Z-Wave JS upgraded to version 15.19.0
    • Z-Wave server upgraded to version 3.5.0
    • Enhanced configuration file support and device fingerprints

✏️ Tip: You can customize this high-level summary in your review settings.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elibl

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 11, 2026 16:59
@elibl elibl changed the title built and tested locally with emulated hardware bump Z-Wave JS Jan 11, 2026
@elibl elibl marked this pull request as ready for review January 11, 2026 17:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 11, 2026

📝 Walkthrough

Walkthrough

Version bump PR updating Z-Wave JS add-on from 0.27.0 to 0.28.0, upgrading underlying Z-Wave JS to 15.19.0 and Z-Wave JS Server to 3.5.0. Changes include changelog documentation and version string updates in build and configuration files.

Changes

Cohort / File(s) Summary
Version and configuration updates
zwave_js/build.yaml, zwave_js/config.yaml
Updated version strings: ZWAVEJS_SERVER_VERSION 3.4.0 → 3.5.0, ZWAVEJS_VERSION 15.15.0 → 15.19.0, and addon config version 0.27.0 → 0.28.0
Changelog documentation
zwave_js/CHANGELOG.md
Added v0.28.0 changelog entry with features (force associations, skip interviewing failed S2 devices), bugfixes (user codes, Supervision usage, log messages, value updates, NVM backup), config changes (firmware fingerprints, endpoint labeling, new devices), and under-the-hood improvements (sdkVersion condition support, linter config updates)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'bump Z-Wave JS' is a generic and vague description that doesn't specify which components are being bumped or provide meaningful detail about the changeset. Consider a more descriptive title like 'Update Z-Wave JS to 15.19.0 and Z-Wave JS Server to 3.5.0' to clearly communicate the primary versions being updated.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @zwave_js/CHANGELOG.md:
- Line 48: Fix the typo in the CHANGELOG entry that mentions the `lastSeen`
field: replace the misspelled word "initalizing" with the correct "initializing"
in the sentence "The `lastSeen` field is now restored when initalizing node
statistics" so it reads "...when initializing node statistics".
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 104349e and 404a20c.

📒 Files selected for processing (3)
  • zwave_js/CHANGELOG.md
  • zwave_js/build.yaml
  • zwave_js/config.yaml
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)

⚙️ CodeRabbit configuration file

*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.

  • Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
  • In step-by-step instructions, front the location phrase in the instructional sentence.
  • In step-by-step instructions, front the 'goal' in the instructional sentence.
  • In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
  • do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'

*/**(html|markdown|md): - Use bold to mark UI strings.

  • If "" are used to mark UI strings, replace them by bold.

  • Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"

  • Use sentence-style capitalization also in headings.

do not comment on HTML used for icons

Avoid flagging inline HTML for embedding videos in future reviews for this repository.

Files:

  • zwave_js/CHANGELOG.md
  • zwave_js/config.yaml
  • zwave_js/build.yaml
🪛 LanguageTool
zwave_js/CHANGELOG.md

[style] ~18-~18: Consider using a different verb for a more formal wording.
Context: ... to have an incorrect previous value

  • Fixed an issue where some 500 series controll...

(FIX_RESOLVE)


[grammar] ~48-~48: Ensure spelling is correct
Context: ...e lastSeen field is now restored when initalizing node statistics

  • Spec compliance: use...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)


[style] ~72-~72: Consider using a different verb for a more formal wording.
Context: ...nt to "Emergency Alarm" notification

  • Fixed an issue where Basic CC values were inc...

(FIX_RESOLVE)


[style] ~141-~141: Consider using a different verb for a more formal wording.
Context: ...bout an unexpected node:net import

  • Fixed an issue where the device class of newl...

(FIX_RESOLVE)


[uncategorized] ~146-~146: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...rs for HomeSeer WS300

  • Add Zooz ZEN78 High Power Relay

Changes under the hood

...

(EN_COMPOUND_ADJECTIVE_INTERNAL)

🔇 Additional comments (3)
zwave_js/config.yaml (1)

2-2: LGTM! Version bump is consistent.

The add-on version has been correctly updated to 0.28.0, matching the Z-Wave JS library version bump documented in the changelog.

zwave_js/build.yaml (1)

9-10: LGTM! Build version constants updated correctly.

Both ZWAVEJS_SERVER_VERSION (3.5.0) and ZWAVEJS_VERSION (15.19.0) have been properly updated to match the versions documented in the changelog.

zwave_js/CHANGELOG.md (1)

3-167: LGTM! Changelog properly documents the release.

The changelog section for version 0.28.0 is well-structured and comprehensively documents the changes across multiple Z-Wave JS versions (15.15.1 through 15.19.0) and Z-Wave JS Server 3.5.0, with appropriate categorization of features, bugfixes, config file changes, and under-the-hood improvements.


- Remove overly strict ASCII event data padding validation in Entry Control CC
- Fixed an issue where an (unexpected) "Node ID added" notification during an ongoing inclusion would cause security bootstrapping to be skipped
- The `lastSeen` field is now restored when initalizing node statistics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Correct the spelling error.

The word "initalizing" should be "initializing".

📝 Proposed fix
-- The `lastSeen` field is now restored when initalizing node statistics
+- The `lastSeen` field is now restored when initializing node statistics
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- The `lastSeen` field is now restored when initalizing node statistics
- The `lastSeen` field is now restored when initializing node statistics
🧰 Tools
🪛 LanguageTool

[grammar] ~48-~48: Ensure spelling is correct
Context: ...e lastSeen field is now restored when initalizing node statistics

  • Spec compliance: use...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

🤖 Prompt for AI Agents
In @zwave_js/CHANGELOG.md at line 48, Fix the typo in the CHANGELOG entry that
mentions the `lastSeen` field: replace the misspelled word "initalizing" with
the correct "initializing" in the sentence "The `lastSeen` field is now restored
when initalizing node statistics" so it reads "...when initializing node
statistics".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant