-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
bump Z-Wave JS #4287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bump Z-Wave JS #4287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
📝 WalkthroughWalkthroughVersion bump PR updating Z-Wave JS add-on from 0.27.0 to 0.28.0, upgrading underlying Z-Wave JS to 15.19.0 and Z-Wave JS Server to 3.5.0. Changes include changelog documentation and version string updates in build and configuration files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @zwave_js/CHANGELOG.md:
- Line 48: Fix the typo in the CHANGELOG entry that mentions the `lastSeen`
field: replace the misspelled word "initalizing" with the correct "initializing"
in the sentence "The `lastSeen` field is now restored when initalizing node
statistics" so it reads "...when initializing node statistics".
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (3)
zwave_js/CHANGELOG.mdzwave_js/build.yamlzwave_js/config.yaml
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)
⚙️ CodeRabbit configuration file
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
*/**(html|markdown|md): - Use bold to mark UI strings.
If "" are used to mark UI strings, replace them by bold.
Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
Use sentence-style capitalization also in headings.
do not comment on HTML used for icons
Avoid flagging inline HTML for embedding videos in future reviews for this repository.
Files:
zwave_js/CHANGELOG.mdzwave_js/config.yamlzwave_js/build.yaml
🪛 LanguageTool
zwave_js/CHANGELOG.md
[style] ~18-~18: Consider using a different verb for a more formal wording.
Context: ... to have an incorrect previous value
- Fixed an issue where some 500 series controll...
(FIX_RESOLVE)
[grammar] ~48-~48: Ensure spelling is correct
Context: ...e lastSeen field is now restored when initalizing node statistics
- Spec compliance: use...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~72-~72: Consider using a different verb for a more formal wording.
Context: ...nt to "Emergency Alarm" notification
- Fixed an issue where Basic CC values were inc...
(FIX_RESOLVE)
[style] ~141-~141: Consider using a different verb for a more formal wording.
Context: ...bout an unexpected node:net import
- Fixed an issue where the device class of newl...
(FIX_RESOLVE)
[uncategorized] ~146-~146: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...rs for HomeSeer WS300
- Add Zooz ZEN78 High Power Relay
Changes under the hood
...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
🔇 Additional comments (3)
zwave_js/config.yaml (1)
2-2: LGTM! Version bump is consistent.The add-on version has been correctly updated to 0.28.0, matching the Z-Wave JS library version bump documented in the changelog.
zwave_js/build.yaml (1)
9-10: LGTM! Build version constants updated correctly.Both ZWAVEJS_SERVER_VERSION (3.5.0) and ZWAVEJS_VERSION (15.19.0) have been properly updated to match the versions documented in the changelog.
zwave_js/CHANGELOG.md (1)
3-167: LGTM! Changelog properly documents the release.The changelog section for version 0.28.0 is well-structured and comprehensively documents the changes across multiple Z-Wave JS versions (15.15.1 through 15.19.0) and Z-Wave JS Server 3.5.0, with appropriate categorization of features, bugfixes, config file changes, and under-the-hood improvements.
|
|
||
| - Remove overly strict ASCII event data padding validation in Entry Control CC | ||
| - Fixed an issue where an (unexpected) "Node ID added" notification during an ongoing inclusion would cause security bootstrapping to be skipped | ||
| - The `lastSeen` field is now restored when initalizing node statistics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the spelling error.
The word "initalizing" should be "initializing".
📝 Proposed fix
-- The `lastSeen` field is now restored when initalizing node statistics
+- The `lastSeen` field is now restored when initializing node statistics📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - The `lastSeen` field is now restored when initalizing node statistics | |
| - The `lastSeen` field is now restored when initializing node statistics |
🧰 Tools
🪛 LanguageTool
[grammar] ~48-~48: Ensure spelling is correct
Context: ...e lastSeen field is now restored when initalizing node statistics
- Spec compliance: use...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
In @zwave_js/CHANGELOG.md at line 48, Fix the typo in the CHANGELOG entry that
mentions the `lastSeen` field: replace the misspelled word "initalizing" with
the correct "initializing" in the sentence "The `lastSeen` field is now restored
when initalizing node statistics" so it reads "...when initializing node
statistics".
built and tested locally with emulated hardware
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.