Skip to content

Adjust edge to edge in BarcodeActivity for API 36 and landscape #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Conversation

TimoPtr
Copy link
Collaborator

@TimoPtr TimoPtr commented May 23, 2025

Summary

BarecodeActivity inset is not working properly if we target API 36
Screenshot_20250523_160046

It is also not working properly without changing the target in landscape
Screenshot_20250523_155720

This PR propose a change so that the overlay is properly displayed.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

image
image

Any other notes

Part of #5328

@TimoPtr TimoPtr requested a review from jpelgrom May 23, 2025 14:08
Copy link

@Gregman-js Gregman-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status bar is dark on light theme.
I think it should be forced to white

WindowCompat.getInsetsController(window, view).isAppearanceLightStatusBars = false
Screenshot 2025-05-23 at 20 38 33

@jpelgrom jpelgrom changed the title Adjust edge to edge in BarecodeActivity for API 36 and landscape Adjust edge to edge in BarcodeActivity for API 36 and landscape May 23, 2025
@TimoPtr TimoPtr requested review from jpelgrom and Gregman-js May 27, 2025 13:53
@TimoPtr TimoPtr merged commit 154122a into main May 28, 2025
19 checks passed
@TimoPtr TimoPtr deleted the feature/edge-to-edge-barcoode branch May 28, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants