Add incoming external bus messages for matter#6872
Open
TimoPtr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces new incoming external bus message types for Matter commissioning and Thread credential import, wiring them through JSON parsing into FrontendMessageHandler events and (currently) a placeholder branch in FrontendViewModel.
Changes:
- Added
matter/commissionandthread/import_credentialsincoming message models with serialization support. - Extended
FrontendMessageHandlerto translate these messages into newFrontendHandlerEventvariants. - Added unit tests covering message parsing and handler event emission for both message types (with/without
id).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/kotlin/io/homeassistant/companion/android/frontend/externalbus/incoming/IncomingExternalBusMessage.kt | Adds new incoming message types for Matter/Thread external bus commands |
| app/src/main/kotlin/io/homeassistant/companion/android/frontend/handler/FrontendMessageHandler.kt | Maps new incoming messages to handler events (and logs receipt) |
| app/src/main/kotlin/io/homeassistant/companion/android/frontend/handler/FrontendHandlerEvent.kt | Introduces new handler events representing Matter commissioning + Thread credential import requests |
| app/src/main/kotlin/io/homeassistant/companion/android/frontend/FrontendViewModel.kt | Adds placeholder handling that currently logs and does not complete the request |
| app/src/test/kotlin/io/homeassistant/companion/android/frontend/externalbus/incoming/IncomingExternalBusMessageTest.kt | Adds JSON deserialization tests for the new message types |
| app/src/test/kotlin/io/homeassistant/companion/android/frontend/handler/FrontendMessageHandlerTest.kt | Adds handler event emission tests for the new message types |
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add incoming external bus messages for matter and mapping into the ViewModel with dumb logs to prepare the impl of the matter onboarding flow.
Checklist