Skip to content

Use GH instead of softprops/action-gh-release#6873

Open
TimoPtr wants to merge 2 commits into
mainfrom
feature/use_gh_instead_of_actions
Open

Use GH instead of softprops/action-gh-release#6873
TimoPtr wants to merge 2 commits into
mainfrom
feature/use_gh_instead_of_actions

Conversation

@TimoPtr
Copy link
Copy Markdown
Member

@TimoPtr TimoPtr commented May 20, 2026

Summary

We should avoid using an external action when we can do the same operation with the tool already available it limits our attack surface. It is also one less thing to update.

This address two warning from zizmor

info[template-injection]: code injection via template expansion
   --> ./.github/workflows/onPush.yml:106:34
    |
106 |         run: gh release edit ${{ steps.rel_number.outputs.version }} --draft=false
    |         --- this run block       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ may expand into attacker-controllable code
    |
    = note: audit confidence → Low
    = note: this finding has an auto-fix

info[superfluous-actions]: action functionality is already included by the runner
  --> ./.github/workflows/onPush.yml:88:15
   |
86 |       - name: Create draft Github Pre-Release
   |         ------------------------------------- this step
87 |         if: github.event.inputs.beta == 'true'
88 |         uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use `gh release` in a script step
   |
   = note: audit confidence → High

Copilot AI review requested due to automatic review settings May 20, 2026 14:11
@TimoPtr TimoPtr requested a review from jpelgrom May 20, 2026 14:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces GitHub Actions supply-chain exposure by replacing softprops/action-gh-release with the built-in gh CLI to create/update the beta GitHub prerelease during the onPush workflow.

Changes:

  • Replace softprops/action-gh-release usage with a bash step that uses gh release view/upload/edit/create
  • Consolidate “create prerelease” and “publish prerelease” logic into a single conditional block

Comment thread .github/workflows/onPush.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@TimoPtr TimoPtr deployed to ui-test May 20, 2026 14:51 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants