Replace logrus with log/slog#634
Conversation
sairon
left a comment
There was a problem hiding this comment.
Looks good!
Needless to say, the reduction of binary size is negligible (~30kB) but having one dependency less is nice anyway. There are some minor nuances, like missing trace level which is now silently ignored and logging falls back to WARN, but I don't see it as a big deal, as we haven't used it explicitly and likely no one will even notice.
Thank you!
sairon
left a comment
There was a problem hiding this comment.
Looks good!
Needless to say, the reduction of binary size is negligible (~30kB) but having one dependency less is nice anyway. There are some minor nuances, like missing trace level which is now silently ignored and logging falls back to WARN, but I don't see it as a big deal, as we haven't used it explicitly and likely no one will even notice.
Thank you!
Large but low complexity PR, replaces logrus with the stdlib log/slog package.
Benefits of this include
The log format produced is different, matter of taste which looks nicer, but I think users are not exposed to it much at all anyway in normal circumstances.