Fix evohome HVAC modes for VisionPro Wifi systems #127605
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes a bug where some (i.e. a very small % of evohome) systems cannot set the HVAC mode and includes tests that confirm the bug is fixed.
The coverage of this test is <80%, but I am reluctant to extend coverage in this PR (e.g. add tests of PRESET modes), as it will make the PR larger.
Obviously, I will add those tests in another PR.
This is a redo of #126407
Type of change
Additional information
VisionPro Wifi systems are compatible with Honeywell (now Resideo) TCC, but have slightly different operating modes (e.g. Off instead of HeatingOff). This was mentioned in #32585 (which was closed when the primary issue was addressed in #32604).
Thus, these specific systems cannot be turned on/off via the UI or with the usual service calls.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: