-
-
Notifications
You must be signed in to change notification settings - Fork 33k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IPP protocol version configurable #128997
base: dev
Are you sure you want to change the base?
Conversation
Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
13155b3
to
69993de
Compare
This is a simple rebase of the closed and locked #115661 @emontnemery requested to change the checkbox to a drop-down menu over in #115661 (comment). However, I disagree with that as this is a simple binary choice and I'd like to keep this change simple. This does obviously not preclude anyone from introducing such a change later. |
The linter config seems broken:
Edit: nevermind, looks like I had an outdated version of ruff installed |
6fe8880
to
bce57ac
Compare
This is ready for review. Could someone please start the CI pipeline? @ctalkington could you approve this? |
This comment was marked as off-topic.
This comment was marked as off-topic.
877ffca
to
7f9d653
Compare
@LorbusChris Please change to a select selector which allows picking version 1.1 or 2.0 instead of a checkbox as requested in #115661 Here's an example of how to do that: core/homeassistant/components/airzone_cloud/config_flow.py Lines 66 to 78 in f428958
Note that the selections can be translated too, but I guess that's not needed in this case core/homeassistant/components/group/strings.json Lines 219 to 233 in f428958
|
@LorbusChris Please click the "Ready for review" button when you've updated |
@emontnemery see #128997 (comment) Again, this is a binary choice and a dropdown menu for it complicates things unnecessarily. |
Adds a checkbox to optionally configure a printer with legacy IPP v1.1 instead of the default v2.0. Fixes: home-assistant#93211
7f9d653
to
9bbafd1
Compare
I'm aware of this PR and know there's been a bit of back and forth. I will do my best to review/approve before the end of the year. |
Is it possible to autodetect by connecting with v2, and if that fails go back to v1? |
thats an idea for manual additions (zeroconf should mean it supports IPP 2.0 per spec) and possibly set a flag on the client for that "session". I might be able to do that upstream with a new parameters that catches first version exception and tries 1.0 |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
ipp: Make IPP protocol version configurable
Adds a checkbox to optionally configure a printer with legacy IPP v1.1 instead of the default v2.0.
Fixes: #93211
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: