-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Switch to PyEzvizApi #135926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Switch to PyEzvizApi #135926
Conversation
Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I am concerned about is that paho-mqtt is pinned to 2.1.0 in the requirements, but HA ships with 1.6, so I am wondering if someone can use this library if they use the MQTT integration
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
The MQTT functionality in this library isn't used yet. I can change the pinned version to 1.6 if that's an issue? |
Like I am assuming 1.6 -> is a breaking change, so I think its better to downgrade it to 1.6, but it should all keep working of course :) |
Pinned paho-mqtt==1.6.1 and bumped the pyezvizapi library version. Also tested locally, no issues. |
btw, given this library change is made necessary to swap one of the current codeowners, I'd suggest to include in the PR amending this aspect too, since the bot will keep raising PRs to them otherwise |
7f10c2c
to
ce25290
Compare
#136130 has been merged |
@frenck @joostlek I think both points raised have been addressed, any further actions required for approval? should we assign someone to the PR (asking cause now @RenierM26 is only owner so does not have a peer pal to cover this) |
Proposed change
Need to update the library from pyezviz to pyezvizapi. The original owner hasn't been available for a long time, and I publish updates to pypi due to email address validation requirements.
I have decided to create a new pypi package with github repository to keep things neat and tidy.
Old github compare (just to make things easier)
BaQs/pyEzviz@0.2.2.4...1.0.0.6
New library:
https://github.com/RenierM26/pyEzvizApi/releases
RenierM26/pyEzvizApi@1.0.0.0...1.0.0.7
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: