Skip to content

Switch to PyEzvizApi #135926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

RenierM26
Copy link
Contributor

@RenierM26 RenierM26 commented Jan 18, 2025

Proposed change

Need to update the library from pyezviz to pyezvizapi. The original owner hasn't been available for a long time, and I publish updates to pypi due to email address validation requirements.

I have decided to create a new pypi package with github repository to keep things neat and tidy.

Old github compare (just to make things easier)
BaQs/pyEzviz@0.2.2.4...1.0.0.6

New library:
https://github.com/RenierM26/pyEzvizApi/releases
RenierM26/pyEzvizApi@1.0.0.0...1.0.0.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@RenierM26 RenierM26 mentioned this pull request Jan 18, 2025
19 tasks
@RenierM26 RenierM26 marked this pull request as ready for review January 18, 2025 17:31
@joostlek joostlek changed the title EZVIZ dependancy change. Switch to PyEzvizApi Jan 19, 2025
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I am concerned about is that paho-mqtt is pinned to 2.1.0 in the requirements, but HA ships with 1.6, so I am wondering if someone can use this library if they use the MQTT integration

@home-assistant home-assistant bot marked this pull request as draft January 19, 2025 11:10
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@RenierM26
Copy link
Contributor Author

The MQTT functionality in this library isn't used yet. I can change the pinned version to 1.6 if that's an issue?

@joostlek
Copy link
Member

Like I am assuming 1.6 -> is a breaking change, so I think its better to downgrade it to 1.6, but it should all keep working of course :)

@RenierM26
Copy link
Contributor Author

Pinned paho-mqtt==1.6.1 and bumped the pyezvizapi library version.

Also tested locally, no issues.

@RenierM26 RenierM26 marked this pull request as ready for review January 19, 2025 15:57
@home-assistant home-assistant bot requested a review from joostlek January 19, 2025 15:57
@frenck
Copy link
Member

frenck commented Jan 19, 2025

Not sure if it matters... but looking at the discussion above, the library doesn't pin anything in the package:

CleanShot 2025-01-19 at 19 54 48@2x

The requirements does... but that isn't used for the package distribution 🤷

@srescio
Copy link
Contributor

srescio commented Jan 26, 2025

btw, given this library change is made necessary to swap one of the current codeowners, I'd suggest to include in the PR amending this aspect too, since the bot will keep raising PRs to them otherwise

@RenierM26 RenierM26 force-pushed the update_library_to_pyezvizapi branch from 7f10c2c to ce25290 Compare February 1, 2025 11:18
@dotlambda
Copy link
Contributor

One thing I am concerned about is that paho-mqtt is pinned to 2.1.0 in the requirements, but HA ships with 1.6

#136130 has been merged

@srescio
Copy link
Contributor

srescio commented Apr 5, 2025

@frenck @joostlek I think both points raised have been addressed, any further actions required for approval? should we assign someone to the PR (asking cause now @RenierM26 is only owner so does not have a peer pal to cover this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants