Skip to content

Conversation

@karlowiczpl
Copy link

Breaking change

The Gryf Smart integration is truly an impressive solution. It is based on a distributed RS232 communication system with a local push architecture, ensuring the highest level of security. This setup provides an enormous gateway to the world for the Gryf Smart system, offering both reliability and scalability. It's an innovative approach that opens up a wealth of possibilities for seamless automation and control.

Proposed change

This pull request introduces a new integration called GryfSmart.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I have done only tests for config flow

Checklist

  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [ x] I have followed the perfect PR recommendations
  • [ x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@home-assistant
Copy link

home-assistant bot commented Feb 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 8, 2025 10:13
@karlowiczpl karlowiczpl marked this pull request as ready for review February 8, 2025 10:16
@zweckj
Copy link
Member

zweckj commented Feb 8, 2025

Please wait with this PR until the base integration has been merged. Thanks!

@zweckj zweckj closed this Feb 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants