Fix nordpool Not to return Unknown if price is exactly 0 #140647
Draft
+135
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @98ultimate
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
integration: nordpool
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
98ultimate
changed the title
98ultimate
changed the title
frenck
requested changes
Mar 16, 2025
frenck
requested changes
Mar 17, 2025
gjohansson-ST
requested changes
Mar 25, 2025
Comment on lines
+37
to
+42
| result = func(entity)[area][index] | ||
| if result is None: | ||
| return None | ||
| if result == 0: | ||
| return float(0) | ||
| return result / 1000 |
There was a problem hiding this comment.
Suggested change
| result = func(entity)[area][index] | |
| if result is None: | |
| return None | |
| if result == 0: | |
| return float(0) | |
| return result / 1000 | |
| if (result := func(entity)[area][index]) is not None: | |
| return result / 1000 | |
| return None |
| @@ -10,191 +10,191 @@ | |||
| "deliveryEnd": "2024-11-05T00:00:00Z", | |||
| "entryPerArea": { | |||
| "SE3": 250.73, | |||
| "SE4": 283.79 | |||
| "SE4": 0.0 | |||
There was a problem hiding this comment.
Let's change one and not all of them.
| async def test_sensor_current_price_is_0( | ||
| hass: HomeAssistant, load_int: ConfigEntry | ||
| ) -> None: | ||
| """Test the Nord Pool sensor.""" |
There was a problem hiding this comment.
We can include all of these in the same test instead of 3 different, and also update the docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes or closes issue: fixes #140646
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: