-
-
Notifications
You must be signed in to change notification settings - Fork 33k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show internet radio station if now artist is available in Cambridge Audio #140716
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @noahhusby, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpick, LGTM 👍
Thanks, @Solmath
You might want to replace "now" in the title of this PR with "no" ;-) |
Breaking change
Proposed change
Currently the media control card does not display the current internet radio station for the CXN100.
For all the stations I checked, the artist is already part of the song title received from the station and the artist attribute is empty. Both the CXN100 and the StreamMagic app use the then empty artist spot to display station information.
To mimick this behaviour, the radio station should be displayed instead of the artist if the source is internet radio and the artist is not available.
I also added the media_channel attribute which contains the internet radion station now.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: