Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default name for Tapo P304M that can't be named #141069

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nicosemp
Copy link

Proposed change

Tapo P304M is a power strip with 4 sockets that can be controlled individually.

Since the Tapo P304M can't be named in the Tapo app, entities are created with unnamed_p304m_... as id prefix. Only the four sockets can be renamed (default is "Tapo Plug 1" with numbers 1 to 4). Renaming 64 entity ids by hand is painful, so a default name like "Tapo P304M" would be nice. It would also result in id prefixes being tapo_p304m_....

This PR is a draft to explore the possibilities to achieve the desired result.
Currently the only change is inside the get_device_name method. If the device has no alias and parent is falsy, then I added an additional check for device.model == "P304M" to return a default "Tapo P304M".

Critical points I'm looking for feedback on:

  • This solves the entity ids problem, as they all start with tapo_p304m_... now. However I'm not sure if this is the right chunk of code to accomplish this. Maybe it should be done wherever this device_name is turned to snake_case and used to assemble the entity ids.
  • The Entity name is still "None P304M". This can be easily renamed from the frontend, but it would be nice to find where it's set and use a similar if check to set the same string as a default.

This aims to be a non-breaking fix.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@nicosemp nicosemp marked this pull request as ready for review March 21, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapo P304M entities are always registered as unnamed_p304m_name_of_entity
3 participants