Default name for Tapo P304M that can't be named #141069
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Tapo P304M is a power strip with 4 sockets that can be controlled individually.
Since the Tapo P304M can't be named in the Tapo app, entities are created with
unnamed_p304m_...
as id prefix. Only the four sockets can be renamed (default is "Tapo Plug 1" with numbers 1 to 4). Renaming 64 entity ids by hand is painful, so a default name like "Tapo P304M" would be nice. It would also result in id prefixes beingtapo_p304m_...
.This PR is a draft to explore the possibilities to achieve the desired result.
Currently the only change is inside the
get_device_name
method. If the device has noalias
andparent
is falsy, then I added an additional check fordevice.model == "P304M"
to return a default"Tapo P304M"
.Critical points I'm looking for feedback on:
tapo_p304m_...
now. However I'm not sure if this is the right chunk of code to accomplish this. Maybe it should be done wherever thisdevice_name
is turned to snake_case and used to assemble the entity ids.This aims to be a non-breaking fix.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: