Skip to content

Conversation

@foxel
Copy link
Contributor

@foxel foxel commented Apr 3, 2025

Proposed change

Adds reconfiguration ability to Keenetic NDMS2 integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: implements feature request Change password to keenetic_ndms2 frontend#24890
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@foxel
Copy link
Contributor Author

foxel commented Apr 21, 2025

Hi @MartinHjelmare . Can you or some one else please do a review of this code?

@MartinHjelmare
Copy link
Member

Why did you tag me?

Please split the PR so the fix is in a separate PR from the new feature (reconfigure flow).

@MartinHjelmare MartinHjelmare marked this pull request as draft April 21, 2025 12:55
@foxel foxel force-pushed the keenetic-reconfigure branch from 63a8981 to c502d5c Compare April 22, 2025 18:16
@foxel
Copy link
Contributor Author

foxel commented Apr 22, 2025

Why did you tag me?

Please split the PR so the fix is in a separate PR from the new feature (reconfigure flow).

Hi @MartinHjelmare . I've tagged you because you were the last one involved in my PRs review :)

I've separated the fix changes from the improvements. THis one now holds only the improvements. The fix was moved to #143475

@foxel foxel force-pushed the keenetic-reconfigure branch from c502d5c to 0d8b94b Compare June 7, 2025 19:30
Introduce a reconfiguration flow to allow updates to existing configuration entries. This includes a new `async_step_reconfigure` method, updated config flow handling, and additional tests for reconfiguration logic.
@foxel foxel force-pushed the keenetic-reconfigure branch from 0d8b94b to 98cc346 Compare June 20, 2025 23:17
@foxel foxel marked this pull request as ready for review June 20, 2025 23:17
@home-assistant home-assistant bot marked this pull request as draft June 23, 2025 21:52
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@foxel foxel marked this pull request as ready for review June 24, 2025 05:37
@home-assistant home-assistant bot requested a review from joostlek June 24, 2025 05:37
@edenhaus edenhaus removed the bugfix label Jul 2, 2025
@frenck frenck requested a review from Copilot July 3, 2025 20:39
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for reconfiguring an existing Keenetic NDMS2 integration without deleting and re-adding it.

  • Introduces async_step_reconfigure and handles SOURCE_RECONFIGURE in config_flow.py
  • Adds a new abort reason "reconfigure_successful" to strings.json
  • Adds MOCK_RECONFIGURE test data and a test_reconfigure case in test_config_flow.py

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/components/keenetic_ndms2/init.py Define MOCK_RECONFIGURE test inputs
tests/components/keenetic_ndms2/test_config_flow.py Add test_reconfigure flow and import new mocks
homeassistant/components/keenetic_ndms2/strings.json Add "reconfigure_successful" abort message
homeassistant/components/keenetic_ndms2/config_flow.py Implement reconfigure logic and import SOURCE_RECONFIGURE

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @foxel 👍

../Frenck

@frenck frenck dismissed joostlek’s stale review July 5, 2025 06:52

Comments addressed

@frenck frenck merged commit 275d390 into home-assistant:dev Jul 5, 2025
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants