-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add reconfiguration support for keenetic_ndms2 integration #142191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @MartinHjelmare . Can you or some one else please do a review of this code? |
|
Why did you tag me? Please split the PR so the fix is in a separate PR from the new feature (reconfigure flow). |
63a8981 to
c502d5c
Compare
Hi @MartinHjelmare . I've tagged you because you were the last one involved in my PRs review :) I've separated the fix changes from the improvements. THis one now holds only the improvements. The fix was moved to #143475 |
c502d5c to
0d8b94b
Compare
Introduce a reconfiguration flow to allow updates to existing configuration entries. This includes a new `async_step_reconfigure` method, updated config flow handling, and additional tests for reconfiguration logic.
0d8b94b to
98cc346
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for reconfiguring an existing Keenetic NDMS2 integration without deleting and re-adding it.
- Introduces
async_step_reconfigureand handlesSOURCE_RECONFIGUREinconfig_flow.py - Adds a new abort reason
"reconfigure_successful"tostrings.json - Adds
MOCK_RECONFIGUREtest data and atest_reconfigurecase intest_config_flow.py
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/components/keenetic_ndms2/init.py | Define MOCK_RECONFIGURE test inputs |
| tests/components/keenetic_ndms2/test_config_flow.py | Add test_reconfigure flow and import new mocks |
| homeassistant/components/keenetic_ndms2/strings.json | Add "reconfigure_successful" abort message |
| homeassistant/components/keenetic_ndms2/config_flow.py | Implement reconfigure logic and import SOURCE_RECONFIGURE |
Co-authored-by: Copilot <[email protected]>
frenck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @foxel 👍
../Frenck
Proposed change
Adds reconfiguration ability to Keenetic NDMS2 integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: