Add new Volvo integration #142994
Open
Add new Volvo integration #142994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
new-integration
integration: volvo
quality-scale
labels
This was referenced Apr 15, 2025
|
Test is failing on an unrelated component: |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
erwindouna
suggested changes
Apr 16, 2025
|
I've marked it ready for review again, while knowing there are still two open questions/remarks:
|
NoRi2909
reviewed
Apr 17, 2025
19 tasks
joostlek
requested changes
Jun 23, 2025
Comment on lines
212
to
257
| async def _mock_api_client( | ||
| hass: HomeAssistant, | ||
| aioclient_mock: AiohttpClientMocker, | ||
| *, | ||
| single_vin: bool = False, | ||
| api_key_failure: bool = False, | ||
| ) -> None: | ||
| aioclient_mock.clear_requests() | ||
| aioclient_mock.post( | ||
| TOKEN_URL, | ||
| json=SERVER_TOKEN_RESPONSE, | ||
| ) | ||
|
|
||
| vins = [{"vin": DEFAULT_VIN}] | ||
|
|
||
| if not single_vin: | ||
| vins.append({"vin": "YV10000000AAAAAAA"}) | ||
|
|
||
| if api_key_failure: | ||
| aioclient_mock.get( | ||
| f"{_API_URL}{_API_CONNECTED_ENDPOINT}", | ||
| exc=VolvoApiException(), | ||
| ) | ||
| else: | ||
| aioclient_mock.get( | ||
| f"{_API_URL}{_API_CONNECTED_ENDPOINT}", | ||
| json={ | ||
| "data": vins, | ||
| }, | ||
| ) | ||
|
|
||
| vehicle_data = await async_load_fixture_as_json(hass, "vehicle", DEFAULT_MODEL) | ||
| aioclient_mock.get( | ||
| f"{_API_URL}{_API_CONNECTED_ENDPOINT}/{DEFAULT_VIN}", | ||
| json={ | ||
| "data": vehicle_data, | ||
| }, | ||
| ) | ||
|
|
||
| vehicle_data = await async_load_fixture_as_json(hass, "vehicle", "xc90_petrol_2019") | ||
| aioclient_mock.get( | ||
| f"{_API_URL}{_API_CONNECTED_ENDPOINT}/YV10000000AAAAAAA", | ||
| json={ | ||
| "data": vehicle_data, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Ideally we would just mock out the object like we do in the other tests to stay consistent
There was a problem hiding this comment.
Code has been refactored, but now I do not have 100% coverage anymore on api.py. Line 38 is missing, but I'm not sure how to cover that. Any idea?
zweckj
reviewed
Jun 24, 2025
zweckj
reviewed
Jun 25, 2025
Month is not a supported value for the `DURATION` device class
frenck
requested review from
Copilot
and removed request for
hanwg and
erwindouna
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a brand-new Volvo integration for Home Assistant, complete with OAuth2 config flow, update coordinators, sensor entities, and a comprehensive test suite.
- Adds
volvointegration includingsensor.py,coordinator.py,config_flow.py, and application-credentials support. - Implements three coordinators for staggered update intervals and error handling.
- Provides extensive pytest fixtures, tests, and snapshot files for multiple vehicle models.
Reviewed Changes
Copilot reviewed 54 out of 57 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/volvo/manifest.json | Defined metadata, dependencies, codeowners, and quality scale |
| homeassistant/components/volvo/config_flow.py | OAuth2 config flow with API key and VIN steps, plus reauth/reconfigure logic |
| homeassistant/components/volvo/coordinator.py | Three DataUpdateCoordinator classes managing different update intervals |
| homeassistant/components/volvo/sensor.py | Sensor entity definitions mapping API fields to HA entities |
| tests/components/volvo/ | New tests for init, coordinator, sensor, config flow, and supporting fixtures |
Comments suppressed due to low confidence (1)
tests/components/volvo/conftest.py:40
- The
full_modelfixture is only parametrized with the electric model; consider adding diesel and petrol models (e.g.,s90_diesel_2018,xc90_petrol_2019) to this list to ensure init and coordinator tests cover all vehicle types.
@pytest.fixture(params=[DEFAULT_MODEL])
|
Volvo released a new version of their energy endpoint, along with new scopes to use. While they mention the old version will still be accessible for 6 months, it appears we cannot sign in anymore with the previous scopes. I have updated the integration to use the new endpoint version, here's a summary of what's changed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This new integration allows you to integrate your Volvo vehicle in Home Assistant.
There was already a Volvo integration, but the API used was deprecated and the integration is no longer maintained. I've chosen to make a completely new integration instead of rebuilding the existing one mainly because the deprecated integration uses the
volvooncalldomain. "On Call" is a reference to the marketing name of the deprecated Volvo API. This new integration usesvolvowhich is agnostic of any API marketing name.Ideally, the old
volvooncallintegration is removed.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: