Provide clear solution to error message #143690
Conversation
I pulled the text that I've added to the end of the error message directly from the integration page. My suspicion, based on my own troubleshooting, took me into many different places but ended up at this line of text which solved my issue. My idea is by surfacing this text within the setup flow it will allow others to more easily get their Roku devices configured for use.
home-assistant
bot
added
cla-needed
code-quality
integration: roku
small-pr
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @gileswells
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| @@ -16,7 +16,7 @@ | |||
| } | |||
| }, | |||
| "error": { | |||
| "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]" | |||
| "cannot_connect": "[%key:common::config_flow::error::cannot_connect%] If you are having issues connecting, you may have to adjust the settings on your Roku device to allow local control. The common setting is: `Settings / System / Advanced / Control by mobile apps / Network access`" | |||
There was a problem hiding this comment.
Simply appending text to the common key reference will not work. This needs to be completely reworded then.
|
I've marked this PR in draft, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
I pulled the text that I've added to the end of the error message directly from the integration page. My suspicion, based on my own troubleshooting, took me into many different places but ended up at this line of text which solved my issue. My idea is by surfacing this text within the setup flow it will allow others to more easily get their Roku devices configured for use.
Proposed change
Surface debugging instructions from the integration page directly in the error message to allow for faster debugging of setup failures and proceed with device configuration without needing to dig around too much in documentation.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: