-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Meteo France: split mapping of French states between daily and hourly forecasts #143710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
I just noticed the error but I cannot bake cake with that, can someone please explain what this is and if I should resolve it and 'how' ? |
Error disappeared with the branch being upgraded....not sure if this is odd :) |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To move these pull requests forward, I prefer #146965 over this one.
The hourly and daily lists have been duplicated and it's just the ciel clair that is moved from clear_night to sunny in daily. That means, when more states are being discovered, the state needs to be added to both hourly and daily map, which is imho likely to divert sooner or later.
It's the API failing to provide the correct state for daily forecasts, so it may end up being fixed and then the lists can be deduplicated again.
Whatsoever, this pull request also adds new discovered states, which should be accepted if the other one gets merged over this one.
|
closed, comments are fair but only because the owner has not started to (ask someone to) verify which of the states are still active. The duplication only exists because there is no definitive lis tfrom MF to show which state is active and used in what situation....all in all this will grow till someone cleans it up. |
Proposed change
Meteo France webservices are sometimes providing the same state for daily and hourly forecasts, whereas in reality these should be treated differently (see related issue 143593 below)
This bug(?) fix allows to map French states separately for daily and hourly forecasts making it more flexible towards the API
Bug fix also addresses missing state(s):
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: