Skip to content

Conversation

@vingerha
Copy link
Contributor

@vingerha vingerha commented Apr 26, 2025

Proposed change

Meteo France webservices are sometimes providing the same state for daily and hourly forecasts, whereas in reality these should be treated differently (see related issue 143593 below)
This bug(?) fix allows to map French states separately for daily and hourly forecasts making it more flexible towards the API

Bug fix also addresses missing state(s):

  • Averses de pluie et neige
  • Averses de grêle

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of meteo_france can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign meteo_france Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@vingerha
Copy link
Contributor Author

I just noticed the error but I cannot bake cake with that, can someone please explain what this is and if I should resolve it and 'how' ?

@vingerha
Copy link
Contributor Author

vingerha commented May 2, 2025

I just noticed the error but I cannot bake cake with that, can someone please explain what this is and if I should resolve it and 'how' ?

Error disappeared with the branch being upgraded....not sure if this is odd :)

@home-assistant home-assistant bot marked this pull request as draft June 23, 2025 14:31
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@vingerha vingerha marked this pull request as ready for review June 24, 2025 05:17
@home-assistant home-assistant bot requested a review from joostlek June 24, 2025 05:17
Copy link
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To move these pull requests forward, I prefer #146965 over this one.

The hourly and daily lists have been duplicated and it's just the ciel clair that is moved from clear_night to sunny in daily. That means, when more states are being discovered, the state needs to be added to both hourly and daily map, which is imho likely to divert sooner or later.

It's the API failing to provide the correct state for daily forecasts, so it may end up being fixed and then the lists can be deduplicated again.

Whatsoever, this pull request also adds new discovered states, which should be accepted if the other one gets merged over this one.

@vingerha vingerha closed this Jul 1, 2025
@vingerha
Copy link
Contributor Author

vingerha commented Jul 1, 2025

closed, comments are fair but only because the owner has not started to (ask someone to) verify which of the states are still active. The duplication only exists because there is no definitive lis tfrom MF to show which state is active and used in what situation....all in all this will grow till someone cleans it up.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
@vingerha vingerha deleted the meteo_france_split_fc branch November 23, 2025 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meteo France : API provides clear sky (Ciel clair) both for daily as well as a hourly forecasts

4 participants