-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Bump xiaomi-ble to 0.38.0 #143885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump xiaomi-ble to 0.38.0 #143885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @Jc2k, @Ernst79, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
582f237
to
3336b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
../Frenck
@frenck Hi, I have updated the PR description, thank you for your reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please hit the Ready for review button when you think it is ready. Otherwise, it will stay as draft PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Cerallin 👍
Breaking change
Proposed change
Bump xiaomi-ble to v0.38.0. Release notes: https://github.com/Bluetooth-Devices/xiaomi-ble/releases/tag/v0.38.0
This version adds support for XMWS01XS, a 2-button switch.
Type of change
Additional information
xiaomi-ble
,XMWS01XS
. Now I have just tested it with homeassistant and it worked well.Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: