-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Fail tests which leak hass instances #143938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
f30a900
to
3548bd2
Compare
If you are looking for more lrus, |
8ccaa21
to
e711e93
Compare
Some of the leakage is caused by python/cpython#133543, worked around by removing some |
fbd55ac
to
3be9553
Compare
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
A lot of memory is leaked (or technically, kept until the test session is finished) because tests are parametrized with mutable objects which end up directly or indirectly referencing The most common cases are:
Parametrizing like this is suggested in the |
Proposed change
Fail tests which leak many hass instances
Not at all ready for merge, the PR is opened to gain some understanding about how common the issue is
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: