-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
Fix non-reuse of the service name and allow user to specify their own name #143986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix non-reuse of the service name and allow user to specify their own name #143986
Conversation
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I run also this on docker container and it's so annoying to press every time the button 😭 |
…n of the integration && allow user to specify his custom name
3206b81
to
4d6e3d6
Compare
Why don't you use location name? |
Not sure to get it... location of what ? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
The service name assigned by this integration and stored in a file corresponds to the hostname. However, the integration does not retrieve it from the previously saved file on reload or restart.
When running Home Assistant in a Docker container without setting a fixed hostname, users must re-authenticate with the Freebox each time the container is recreated. This process requires pressing a physical button on the device to grant authorization. This PR resolves the issue.
Additionally, when adding a new Freebox, users now have the option to specify a custom name instead of using the hostname.
When adding the integration :



When validating on the device :
In the administration page of the device (first row, before, after on the second row) :
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: