Skip to content

Fix non-reuse of the service name and allow user to specify their own name #143986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Xavinooo
Copy link

@Xavinooo Xavinooo commented Apr 30, 2025

Proposed change

The service name assigned by this integration and stored in a file corresponds to the hostname. However, the integration does not retrieve it from the previously saved file on reload or restart.

When running Home Assistant in a Docker container without setting a fixed hostname, users must re-authenticate with the Freebox each time the container is recreated. This process requires pressing a physical button on the device to grant authorization. This PR resolves the issue.

Additionally, when adding a new Freebox, users now have the option to specify a custom name instead of using the hostname.

When adding the integration :
conf
When validating on the device :
image
In the administration page of the device (first row, before, after on the second row) :
freebox

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign freebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@taiQui
Copy link

taiQui commented May 1, 2025

I run also this on docker container and it's so annoying to press every time the button 😭
Need this

…n of the integration && allow user to specify his custom name
@Xavinooo Xavinooo force-pushed the resuse_service_name_and_user_specify_name branch from 3206b81 to 4d6e3d6 Compare May 1, 2025 21:41
@joostlek
Copy link
Member

joostlek commented May 7, 2025

Why don't you use location name?

@Xavinooo
Copy link
Author

Xavinooo commented May 7, 2025

Why don't you use location name?

Not sure to get it... location of what ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freebox - Docker - AuthorizationError: Authorization timed out
4 participants