Add Deadlock (SecureMode) support to the Yale Access Bluetooth integration #144107
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @michaelp1742,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
-
370cdd4a37eb55b581ea50f6dad8d15086a1efc9- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
9a8df6408821f3d6c84af4b71e3f4039dfb3994a- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?. -
ff52ede787c1bee764f06cafa3b6e4866f45cd57- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <[email protected]>"[email protected]" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
home-assistant
bot
added
bugfix
cla-error
integration: yalexs_ble
new-feature
new-platform
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Co-authored-by: J. Nick Koston <[email protected]>
|
@michaelp1742 Hey, just checking in—were you planning to continue with this PR? If not, that’s totally fine. I’d like to keep working on the integration, but the current breaking changes are blocking further progress. If you don’t plan to continue, I’ll need to revert the changes to |
|
I’m not sure it’s a good idea to implement this as a switch, since that would bypass standard voice assistant safeguards for unlocking. For security reasons, it would be better to expose this as a separate lock entity—perhaps something like secure_mode_lock. That way, we retain the existing lock behavior while giving users an explicit and guarded way to enable secure mode. |
|
This approach works fine. The secure mode lock will still engage even if the device doesn't support secure mode, but it won't indicate that it's in secure mode in that case. I think we can merge this after the docs are updated. |
Proposed change
Yale locks such as the YUR/DEL/1/SIL have a deadlock mode as well as the external locked state.
These Yale locks have three valid end-states, Unlocked, Locked, and Deadlocked (SecureMode). The lock can be Deadlocked directly while Locked or Unlocked but a Deadlocked lock can only be unlocked.
This PR adds support for both the SecureMode command and status reporting.
Lock status reporting simply treats SecureMode as equivalent to a Locked state.
The SecureMode command is implemented as a second lock which deadlocks the lock when switched on and unlocks it when switched off. The lock is disabled by default as the majority of Yale locks do not implement SecureMode and the lock should be enabled for testing by the end user.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools: