Skip to content

Implement NVR download for Reolink recordings #144121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented May 2, 2025

Breaking change

Proposed change

Implement NVR download for Reolink recordings instead of using FLV streams.
Advantages:

  • recordings can now be split in chunks of 5 minutes (hardcoded as a CONSTANT in HA, can be changed) instead of the full file duration of 60 minutes
  • the FLV stream can not be skipped ahead, so you need to watch the full 60 minutes to reach the end, with this download method you can skip ahead as soon as that portion of the mp4 is downloaded, download goes pretty fast depending on NVR upload speed and the network speed.

Disadvantages:

  • startup is a few seconds slower since this download method takes 2 steps: 1) request the NVR to prepare a mp4 for the 5 minute time chunk from the original 60 minute file which is on the NVR harddrive, this takes 1-2 seconds (extra time), 2) actually start downloading the chunk.mp4 once the NVR indicates the preperation is done. with the FLV method you can emidiatly start streaming (only step 2).

TO DO:

  • adjust tests
  • requires a new release of reolink-aio

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review May 12, 2025 05:45
@starkillerOG starkillerOG requested a review from edenhaus May 12, 2025 18:54
@edenhaus
Copy link
Member

I tested this change.
Why can't I jump forward in time on the 5 minutes video?
This is possible on the recorded videos when the camera is connected directly via HA.

Is this change slowing down media browsing? Compared to my production instance (running 2025.5.3), browsing through the recorded video is significantly slower.

@edenhaus
Copy link
Member

As discussed offsite, I will merge it as it is. But in a follow-up PR, we need to fix that currently, the user can't jump forward in time

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starkillerOG 👍

@edenhaus edenhaus merged commit a3b7cd7 into home-assistant:dev May 26, 2025
34 checks passed
@starkillerOG starkillerOG deleted the reolink_seek branch May 26, 2025 13:42
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants